Restructure public api models for charge manager #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elvishrdz
force-pushed
the
feature/refactor-public-charge-manager
branch
from
26faeef to
f97da01
Compare
juanjecilla
approved these changes
Nov 4, 2025
| @@ -0,0 +1,8 @@ | |||
| package de.elvah.charge.public_api.model | |||
|
|
|||
| public class ChargingSession( | |||
Collaborator
There was a problem hiding this comment.
I know I named the things this way but I was thinking that maybe infinitive instead of -ing would be better, wdyt?
| val isSummaryReady by SessionManager.isSummaryReady.collectAsStateWithLifecycle(false) | ||
| val hasActiveSession by SessionManager.hasActiveSession.collectAsStateWithLifecycle(false) | ||
| val charge by SessionManager.chargeSession.collectAsStateWithLifecycle(null) | ||
| val isSummaryReady by ChargeSessionManager.isSummaryReady.collectAsStateWithLifecycle(false) |
Collaborator
There was a problem hiding this comment.
I tend to prefer only one single state where we can hold all related stuff to the component. What do you thing? Maybe not for this PR but change it in the future.
Elvishrdz
force-pushed
the
feature/refactor-public-charge-manager
branch
from
5d466d2 to
3c57cb4
Compare
juanjecilla
approved these changes
Nov 5, 2025
Elvishrdz
merged commit c743f78
into
feature/restructure-sdk-ui-component-source
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist