Fix RUSTIC-CARGO-TEST

[mak-kirkland]

To only use the last stored arguments if
RUSTIC-CARGO-USE-LAST-STORED-ARGUMENTS is non-nil.

Otherwise once we run only a single test (e.g via
RUSTIC-CARGO-CURRENT-TEST), then trying to run all tests will still only run the last current test.

[psibi]

@SiberzK Thanks for the PR!

Otherwise once we run only a single test (e.g via
RUSTIC-CARGO-CURRENT-TEST), then trying to run all tests will still only run the last current test.

I tried to test the behavior that you have specified, but I'm unable to reproduce. It could be because I have mis-understood it. Can you give me a reproducible steps of the issue that this PR is trying to fix it ?

[mak-kirkland]

@SiberzK Thanks for the PR!

Otherwise once we run only a single test (e.g via
RUSTIC-CARGO-CURRENT-TEST), then trying to run all tests will still only run the last current test.

I tried to test the behavior that you have specified, but I'm unable to reproduce. It could be because I have mis-understood it. Can you give me a reproducible steps of the issue that this PR is trying to fix it ?

1. Make sure rustic-cargo-use-last-stored-arguments is set to NIL.
2. Call rust-cargo-test. This will run all tests.
3. Move cursor to within a test definition and call rustic-cargo-current-test. This will run only a single test.
4. Call rust-cargo-test. This continues to run only that one test, whereas before (in step 2), it was running all tests.

Since rustic-cargo-use-last-stored-arguments was set to NIL, calling rust-cargo-test should respect that.

[psibi]

Thanks! I can reproduce it. Do you think you can add tests for this ? I'm merging this nonetheless.

[psibi]

I'm merging this nonetheless.

I spoke soon, can you see why the tests are failing ?

[mak-kirkland]

I'm merging this nonetheless.

I spoke soon, can you see why the tests are failing ?

Hey, I've done some digging and found that the test was changed in commit de8ec9f to no longer use the default arguments.

This was done to "fix" the test after 1280136, which introduced the bug this PR attempts to fix. In fact this change was simply hiding the bug.

I've pushed a 2nd commit to this PR reverting the relevant part of de8ec9f and restoring the original behaviour.

rustic-cargo-test-test should now pass 👍

[psibi]

Thanks!