Set type=module #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
requested changes
Mar 27, 2025
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
While I agree with the change, I would like to add "request changes" here to prevent us from accidentally merging it.
I'm not against merging this at all, but I think we need to implement our testing infrastructure in this repo before we go anywhere near such a big change. You're right to point out the current limitations too 👍
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables so much for us, it's really hard to not have <3
Users of vite already support type=module v2 addons 🎉
Blocked: