Skip to content

Commit 1c84388

Browse files
Fix some lint
1 parent 5f70e6b commit 1c84388

File tree

86 files changed

+618
-613
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

86 files changed

+618
-613
lines changed

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
# misc
99
/coverage/
10+
/vendor/
1011
!.*
1112
.*/
1213

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ module.exports = {
3939
'ember/no-classic-components': 'off',
4040
'ember/no-computed-properties-in-native-classes': 'off',
4141
'ember/no-get': 'off',
42+
'ember/no-runloop': 'off',
4243

4344
// Best practice
4445
'no-duplicate-imports': 'error',

.stylelintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
22

33
module.exports = {
4-
extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
4+
extends: ['stylelint-config-standard-scss', 'stylelint-prettier/recommended'],
55
};

.template-lintrc.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@
33
module.exports = {
44
extends: 'recommended',
55
rules: {
6+
'no-at-ember-render-modifiers': false,
67
'no-down-event-binding': false,
78
'no-negated-condition': false,
89

910
// TODO: enable these rules
11+
'no-builtin-form-components': false,
1012
'no-positive-tabindex': false,
1113
},
1214
};

app/components/deprecations-toolbar.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
<Ui::ToolbarDivider />
55

6-
<div class="toolbar__checkbox">
6+
<div class="toolbar-checkbox">
77
<label title="Deprecation workflow">
88
<Input
99
@type="checkbox"

app/components/list-content.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export default class ListContent extends Component.extend(Evented) {
5959
this.layoutService.on(
6060
'content-height-update',
6161
this,
62-
this.updateContentHeight
62+
this.updateContentHeight,
6363
);
6464
}
6565

@@ -92,7 +92,7 @@ export default class ListContent extends Component.extend(Evented) {
9292
this.layoutService.off(
9393
'content-height-update',
9494
this,
95-
this.updateContentHeight
95+
this.updateContentHeight,
9696
);
9797
return super.willDestroy(...arguments);
9898
}

app/components/model-types-toolbar.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<Ui::ToolbarDivider />
88

9-
<div class="toolbar__checkbox js-filter-hide-empty-model-types">
9+
<div class="toolbar-checkbox js-filter-hide-empty-model-types">
1010
<label>
1111
<Input
1212
data-test-options-hideEmptyModelTypes
@@ -16,7 +16,7 @@
1616
Hide Empty Model Types
1717
</label>
1818
</div>
19-
<div class="toolbar__checkbox js-filter-order-records-by-count">
19+
<div class="toolbar-checkbox js-filter-order-records-by-count">
2020
<label>
2121
<Input
2222
data-test-options-orderByRecordCount
@@ -26,7 +26,7 @@
2626
Order Models By Record Count
2727
</label>
2828
</div>
29-
<button class="toolbar__radio js-filter" {{on "click" @getStore}} data-test-inspect-store type="button">
29+
<button class="toolbar-radio js-filter" {{on "click" @getStore}} data-test-inspect-store type="button">
3030
Inspect Store
3131
</button>
3232
</div>

app/components/object-inspector.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
<div class="toolbar object-inspector-toolbar">
5454
<button
5555
data-test-object-display-type-grouped
56-
class="toolbar__radio toolbar__radio--first {{
56+
class="toolbar-radio toolbar-radio--first {{
5757
if (eq this.propDisplayType "grouped") "active"
5858
}}"
5959
type="button"
@@ -63,7 +63,7 @@
6363
</button>
6464
<button
6565
data-test-object-display-type-all
66-
class="toolbar__radio {{if (eq this.propDisplayType "all") "active"}}"
66+
class="toolbar-radio {{if (eq this.propDisplayType "all") "active"}}"
6767
type="button"
6868
{{on "click" (fn this.setPropDisplay "all")}}
6969
>

app/components/object-inspector/sort-properties.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export default class SortProperties extends Component {
4646
set(
4747
p,
4848
'isFunction',
49-
p.value.type === 'type-function' || p.value.type === 'type-asyncfunction'
49+
p.value.type === 'type-function' || p.value.type === 'type-asyncfunction',
5050
);
5151
if (p.name == parseInt(p.name)) {
5252
set(p, 'name', parseInt(p.name));

app/components/promise-item.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export default class PromiseItem extends Component {
2929

3030
@computed(
3131
'args.{effectiveSearch,filter}',
32-
'args.model.{isFulfilled,isPending,isRejected,state}'
32+
'args.model.{isFulfilled,isPending,isRejected,state}',
3333
)
3434
get nodeStyle() {
3535
let relevant;
@@ -61,7 +61,7 @@ export default class PromiseItem extends Component {
6161
return htmlSafe(
6262
`padding-left: ${+get(this, 'args.model.level') * 20 + 5}px;${
6363
this.nodeStyle
64-
}`
64+
}`,
6565
);
6666
}
6767

0 commit comments

Comments
 (0)