Skip to content

Conversation

@zffocussss
Copy link

  • http request header
  • http request body size

@zffocussss
Copy link
Author

@gi0baro can you help have a check?

Copy link
Member

@gi0baro gi0baro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zffocussss thank you for your contribution.

Unfortunately, I can't merge this due to the following reasons:

  • it's missing the RSGI protocol implementation. Any change in Granian regarding shared interfaces should be performed on all protocols
  • I find the WSGI implementation to be very hacky (eg: manually patching the scope to store data), and I'm confused on why you del stuff from objects
  • The ASGI implementation is incomplete
  • The response size wouldn't be accurate
  • The overall implementation might have severe performance implications (parsing all headers just to print one or few, usage of re.match, SafeAtoms wrapper, double iteration of the response, etc)

So in general, I think this should be designed quite differently.

@zffocussss
Copy link
Author

@zffocussss thank you for your contribution.

Unfortunately, I can't merge this due to the following reasons:

  • it's missing the RSGI protocol implementation. Any change in Granian regarding shared interfaces should be performed on all protocols
  • I find the WSGI implementation to be very hacky (eg: manually patching the scope to store data), and I'm confused on why you del stuff from objects
  • The ASGI implementation is incomplete
  • The response size wouldn't be accurate
  • The overall implementation might have severe performance implications (parsing all headers just to print one or few, usage of re.match, SafeAtoms wrapper, double iteration of the response, etc)

So in general, I think this should be designed quite differently.

I will consider your comments.I am not a user of rsgi at all.My goal is to make granian work more flexibly than gunicorn + uvicorn any way.
The response size is calculated differently indeed between asgi and wsgi.
Regarding to the performance issues,I agree with you,trying to find a better way to make it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants