feat add query parameter to lb hash policy #7428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inode1
force-pushed
the
feat-consistent-hash-query-param
branch
2 times, most recently
from
dd82c08 to
208dbed
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7428 +/- ##
==========================================
- Coverage 72.28% 71.19% -1.09%
==========================================
Files 231 274 +43
Lines 33999 34830 +831
==========================================
+ Hits 24576 24798 +222
- Misses 7652 8244 +592
- Partials 1771 1788 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Inode1
force-pushed
the
feat-consistent-hash-query-param
branch
2 times, most recently
from
d7a146d to
e7d154b
Compare
arkodg
reviewed
Nov 21, 2025
api/v1alpha1/loadbalancer_types.go
Outdated
| // QueryParameter configures the query parameter hash policy when the consistent hash type is set to QueryParameter. | ||
| // | ||
| // +optional | ||
| QueryParameter *QueryParameter `json:"queryParameter,omitempty"` |
Contributor
There was a problem hiding this comment.
lets rename to queryParam to keep it consistent with the API https://gateway-api.sigs.k8s.io/reference/spec/#httproutematch
Inode1
force-pushed
the
feat-consistent-hash-query-param
branch
from
e7d154b to
8c5e135
Compare
Signed-off-by: i.makarychev <[email protected]> Signed-off-by: i.makarychev <[email protected]>
Inode1
force-pushed
the
feat-consistent-hash-query-param
branch
from
8c5e135 to
35419e3
Compare
zirain
reviewed
Nov 23, 2025
|
|
||
| // QueryParamName defines the query parameter name hashing configuration for consistent hash based | ||
| // load balancing. | ||
| type QueryParam string |
Member
There was a problem hiding this comment.
should we reuse the struct from gwapi?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Support query_parameter as a source for consistent hashing in Envoy Gateway
Which issue(s) this PR fixes:
Fixes #6398
Release Notes: Yes/No