Add MCP filter name to wellknown

[chuangw6]

Signed-off-by: Chuang Wang [email protected]

[botengyao]

Need to fix DCO.

[chuangw6]

DCO

what's DCO? Oh I see. Done

[valerian-roche]

wellknown is deprecated. It does require manual tracking of the very large number of typed extensions in envoy, and has the bad side effect of creating dependency on the main go-control-plane module instead of the envoy submodule.
If users believe this is really valuable this should be moved to a new pkg within the envoy submodule and ideally be autogenerated from the protobufs

[kyessenov]

+1, we don't recommend using filter names in xDS. Envoy just looks up by the type_url.

[chuangw6]

aha I didn't notice the deprecation comment. Cool, so that means, name field doesn't matter (even if it's empty) as long as @type field is correct, right?

            - name: envoy.filters.http.rbac
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.filters.http.rbac.v3.RBAC

[valerian-roche]

aha I didn't notice the deprecation comment. Cool, so that means, name field doesn't matter (even if it's empty) as long as @type field is correct, right?

            - name: envoy.filters.http.rbac
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.filters.http.rbac.v3.RBAC

The name field is used in some context iirc (e.g. if using route level override), but it does not need to be the filter type