Stay compatible with the authenticator apps #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabolcsnagy
force-pushed
the
stay-compatible-with-auth-apps
branch
from
8c4d360 to
bc5b120
Compare
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hold on. I found a bug in it. I guess I need to open a new PR? |
|
Yes, we need a test for the bug too. Thanks! |
|
This has been reverted because it broke base 2fa functionality. I welcome a contribution which adds this back but does not break this test: 52dabf0 Sorry for the trouble and thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will address issue #21.
I believe moving to BigInt broke the TOTP verification because the authenticator apps are still using 4bytes from the generated
hashByteswhile this library uses 8bytes now that it is switched to BigInt.In this PR I essentially mask out the top 32 bits of the BigInt
hotpValfor 6 digit codes allowing it to run with the same value that an authenticator app would.