feat: support languages json/markdown/css #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
commented
Mar 27, 2025
aladdin-add
commented
Mar 27, 2025
nzakas
reviewed
Mar 27, 2025
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
Thanks for circling back to this. I left some comments inline.
Member
Author
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
aladdin-add
changed the title
nzakas
previously approved these changes
Mar 28, 2025
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Would like @mdjermanovic to verify his feedback has been addressed.
nzakas
previously approved these changes
Mar 28, 2025
Co-authored-by: Milos Djermanovic <[email protected]>
mdjermanovic
previously approved these changes
Mar 28, 2025
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas to re-review.
Member
Author
|
@mdjermanovic @nzakas , I pushed a new commit to opt the md config: e3b3ca2 |
snitin315
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #148
resubmit #151