Skip to content

Conversation

@Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Nov 1, 2025

Prerequisites checklist

What is the purpose of this pull request?

This pull request migrates the codebase from the legacy CodeMirror 0.19.x packages to the stable CodeMirror v6 release.

What changes did you make? (Give an overview)

  • Replaced deprecated packages (@codemirror/highlight, @codemirror/tooltip, @codemirror/panel, etc.) with their v6 equivalents.
  • Removed redundant history/bracketMatching from CodeMirror setup. These are included by default.
  • Enabled JSX in editor when ecmaFeatures.jsx is true
  • Upgraded @uiw/react-codemirror from 4.5.1 → ^4.25.2.

Related Issues

Closes #760

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 1, 2025
@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 5943ffb
🔍 Latest deploy log https://app.netlify.com/projects/new-eslint/deploys/6905fa939444980008aa5807
😎 Deploy Preview https://deploy-preview-831--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 5943ffb
🔍 Latest deploy log https://app.netlify.com/projects/hi-eslint/deploys/6905fa9336acc500079412fb
😎 Deploy Preview https://deploy-preview-831--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 5943ffb
🔍 Latest deploy log https://app.netlify.com/projects/es-eslint/deploys/6905fa92e77a06000814dedf
😎 Deploy Preview https://deploy-preview-831--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot eslint-github-bot bot mentioned this pull request Nov 1, 2025
1 task
@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 5943ffb
🔍 Latest deploy log https://app.netlify.com/projects/zh-hans-eslint/deploys/6905fa933bfc9c00089c9b57
😎 Deploy Preview https://deploy-preview-831--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 5943ffb
🔍 Latest deploy log https://app.netlify.com/projects/ja-eslint/deploys/6905fa9356e5fb0008ca7bec
😎 Deploy Preview https://deploy-preview-831--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 5943ffb
🔍 Latest deploy log https://app.netlify.com/projects/fr-eslint/deploys/6905fa93c85e8400083924a8
😎 Deploy Preview https://deploy-preview-831--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 5943ffb
🔍 Latest deploy log https://app.netlify.com/projects/de-eslint/deploys/6905fa93152c3e000848c533
😎 Deploy Preview https://deploy-preview-831--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 5943ffb
🔍 Latest deploy log https://app.netlify.com/projects/pt-br-eslint/deploys/6905fa93e77a06000814dee4
😎 Deploy Preview https://deploy-preview-831--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Nov 2, 2025
@lumirlumir lumirlumir requested a review from a team November 2, 2025 11:06
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Looks good to me on my end; everything seems to be working as expected.

That said, I'm not very familiar with the CodeMirror ecosystem, another review would be helpful.

@lumirlumir lumirlumir moved this from Triaging to Second Review Needed in Triage Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Second Review Needed

Development

Successfully merging this pull request may close these issues.

3 participants