Replace GOLANG_TEST_SHORT with testing.Short() #20873
Open
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the custom environment variable GOLANG_TEST_SHORT. It is currently used by Main tests (TestMain), as we can't skip tests because testing.M doesn't implement testing.TB. It is possible to do a clean os.Exit(0) (current behavior), but calling testing.Short() fails because this function expects flags to be parsed before. So, it is possible to remove the custom behavior (GOLANG_TEST_SHORT) by parsing flags (if required) before calling testing.Short(), then immediately exit if the result is true (-short flag is set). Signed-off-by: Ivan Valdes <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 25 files with indirect coverage changes @@ Coverage Diff @@
## main #20873 +/- ##
==========================================
+ Coverage 69.13% 69.19% +0.06%
==========================================
Files 422 422
Lines 34809 34814 +5
==========================================
+ Hits 24064 24091 +27
+ Misses 9349 9326 -23
- Partials 1396 1397 +1 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the custom environment variable
GOLANG_TEST_SHORT.It is currently used by Main tests (
TestMain), as we can't skip tests becausetesting.Mdoesn't implementtesting.TB. It is possible to do a cleanos.Exit(0)(current behavior), but callingtesting.Short()fails because this function expects flags to be parsed before.So, it is possible to remove the custom behavior (
GOLANG_TEST_SHORT) by parsing flags (if required) before callingtesting.Short(), then immediately exit if the result is true (-shortflag is set).I believe the only place where this environment variable is used is by
tests/integration/clientv3/concurrency(andtests/integration/clientv3/examples). Running with the new approach using only-short, works as expected:Omitting the verbose output, but focus on time spent and the new log line when short is set.
Part of #18409, as I found out about this while working on updating/simplifying test targets.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.