Skip to content

Fix compatibility with radicale >= 3.5.5 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xiretza wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compatibility with radicale >= 3.5.5 #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etesync_dav/radicale/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ def upload(self, href, vobject_item):
href_mapper = HrefMapper(content=etesync_item._cache_obj, href=href)
href_mapper.save(force_insert=True)

return self._get(href)
return (self._get(href), item)
Copy link
Member

@tasn tasn Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks it for older radicale though, right?

I hate it so much that radicale keeps on breaking things and that we keep on needing to upgrade because deps for this are managed on the distro level.


def delete(self, href=None):
"""Delete an item.
Expand Down
2 changes: 1 addition & 1 deletion etesync_dav/radicale/storage_etebase_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def upload(self, href, vobject_item):
href_mapper = HrefMapper(content=etesync_item.cache_item, href=href)
href_mapper.save(force_insert=True)

return self._get(href)
return (self._get(href), item)

def delete(self, href=None):
"""Delete an item.
Expand Down