Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_listandis_tupleare trivial functions that are not even used in the eth_utils code like ineth-utils/eth_utils/abi.py
Line 84 in cdede30
What was wrong?
I was reading the code to know how this library worked since I use it everyday and while reading it saw this two functions that are trivial and aren't being used.
Also would want to ask about
is_boolandis_int. Both are trivial and saw that they are there since inception but I don't know if there is a reason. Every function call in python carries a cost and removing them would be greatHow was it fixed?
Todo:
Cute Animal Picture