Fix 1753 fork criteria #1760
Fix 1753 fork criteria #1760
Conversation
… pre-allocation group terminology (ethereum#1760) * refactor(docs): move `engine_reorg` -> `engine_x` * refactor(all): rename 'engine reorg' to 'engine x' * refactor(all): update lang from 'shared pre-alloc' to 'pre-allocation groups' 1/2 Terminology: - 'shared pre-allocation' → 'pre-allocation groups' - 'shared pre-state' → 'pre-allocation groups' Flags: - `--generate-shared-pre` -> `--generate-grouped-pre-allocs` - `--use-shared-pre` -> `--use-grouped-pre-allocs` Method names updated: - `update_shared_pre_state` → `update_pre_alloc_groups` - `compute_shared_pre_alloc_hash` → `compute_pre_alloc_group_hash` - `shared_pre_alloc_folder_path` → `grouped_pre_allocs_folder_path` * refactor(all): update lang from 'shared pre-alloc' to 'pre-allocation groups' 2/2 * docs: update changelog * refactor(filler): rename flags for consistency with class names Rename command-line flags to align with function and class naming: - --generate-grouped-pre-allocs → --generate-pre-alloc-groups - --use-grouped-pre-allocs → --use-pre-alloc-groups This improves consistency with PreAllocGroups class and related method names throughout the codebase. Updated all flag definitions, config.getoption() calls, property names, and documentation.
SamWilsn
left a comment
SamWilsn
left a comment
There was a problem hiding this comment.
Please run uvx tox -e static before opening a pull request. It's right in the pull request template; you can't miss it.
In london and the dao fork, it looks like you'll need to add an assert isinstance(..., ByBlockNumber) to fork.py to make the type checker happy.
Hi Sam, i have applied the requested changes for type checker by adding assert isinstance(..., ByBlockNumber) to fork.py of london and dao_fork, and i have verified it locally using tox command and all checks passed, sorry for the inconvenience |
2 participants
🗒️ Description
This PR explicitly annotates the FORK_CRITERIA variable with the ForkCriteria supertype across all fork definition files (src/ethereum/forks/*/init.py). This addresses a type-checking issue where the narrower type (e.g., ByBlockNumber) was being inferred, which could lead to API breakage when transitioning to a broader type (e.g., ByTimestamp).
🔗 Related Issues or PRs
Fixes #1753
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture