Skip to content

Conversation

@LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Nov 17, 2025

🗒️ Description

Separate the blockhash preallocation group from the rest of the benchmark pre-allocation.

After doing so, the blockhash benchmark with the release parameter takes ~90 minutes to run. And the rest of the benchmark tests takes roughly 6 hours (reference).
Screenshot 2025-11-18 at 7 05 55 AM

🔗 Related Issues or PRs

Issue #1792

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@LouisTsai-Csie LouisTsai-Csie force-pushed the optimize-benchmark-prealloc branch from 2305b4a to 984424a Compare November 17, 2025 20:51
@LouisTsai-Csie LouisTsai-Csie marked this pull request as ready for review November 18, 2025 13:42
@LouisTsai-Csie LouisTsai-Csie self-assigned this Nov 18, 2025
@LouisTsai-Csie LouisTsai-Csie added A-test-benchmark Area: Tests Benchmarks—Performance measurement (eg. `tests/benchmark/*`, `p/t/s/e/benchmark/*`) C-refactor Category: refactor labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-benchmark Area: Tests Benchmarks—Performance measurement (eg. `tests/benchmark/*`, `p/t/s/e/benchmark/*`) C-refactor Category: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant