Skip to content

Set Cn to identity instead of nil, when deleting a 128-leaf subtree #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set Cn to identity instead of nil, when deleting a 128-leaf subtree #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,9 +1384,9 @@ func (n *LeafNode) Delete(k []byte, _ NodeResolverFn) (bool, error) {

// Clear the corresponding commitment
if k[StemSize] < 128 {
n.c1 = nil
n.c1 = new(Point).SetIdentity()
} else {
n.c2 = nil
n.c2 = new(Point).SetIdentity()
Comment on lines -1387 to +1389
Copy link
Collaborator

@jsign jsign Apr 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new changes are aligned on how NewLeafNode works, right? Look here.

Looks like in that else we aren't doing else if count > 0 {, which means cfg.CommitToPoly is always called (apart from the optimized case of emptyCodeHash) which never return nil.

So maybe this means the current change is a more reasonable action than what we had before this PR?

}

return false, nil
Expand Down
Loading