feat: Add error handling to Commit() function #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds error handling to the
Commit()function in the Verkle tree implementation. Previously, theCommit()function did not return errors, which could lead to silent failures.Changes
VerkleNodeinterface to makeCommit()return(*Point, error)Commit()to properly handle and return errorsCommit()to handle the returned errorCommit()Why
The original implementation did not handle potential errors during commitment computation, which could lead to:
Testing
Commit()and they passRelated Issues