Add registry functions to instantiate models by provider #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync `dev` with `main`
rmitsch
added
refactoring
svlandeg
reviewed
Jan 24, 2024
3 tasks
svlandeg
approved these changes
Mar 18, 2024
Contributor
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
This makes a lot of sense, and it'll be great to make this change before 1.0.0. Virtually good to merge once my few small comments/questions are adressed.
Contributor
|
Did you run the GPU tests? |
3 tasks
Co-authored-by: Sofie Van Landeghem <[email protected]>
Contributor
Author
This passes local GPU tests. |
…osion/spacy-llm into refactor/model-registry-by-provider
svlandeg
reviewed
Apr 22, 2024
svlandeg
approved these changes
Apr 22, 2024
3 tasks
svlandeg
added a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add registry functions to instantiate models by provider. Older, model-specific registry functions will still be available to maintain backwards compatibility, but will not be advertised in the documentation anymore.
Corresponding documentation PR
explosion/spaCy#13288
Types of change
Refactoring.
Checklist
testsandusage_examples/tests, and all new and existing tests passed. This includespytestran with--external)pytestran with--gpu)