update to eslint 9 #6912
Open
update to eslint 9 #6912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
UlisesGascon
approved these changes
Nov 25, 2025
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! It is a great contribution. Thanks @dynst for helping the project ❤️
I will ask @wesleytodd for an additional review just in case we have a different plan for eslint, but AFAIK we are good to go 👍
Member
|
@UlisesGascon There is an open discussion expressjs/discussions#327 |
bjohansebas
requested changes
Nov 25, 2025
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
I definitely prefer that we use neostandard rather than having to look up which rules to apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eslint.org/docs/latest/rules/no-unused-vars#caughterrors
The only noticeable change is that the no-unused-vars lint now warns about unused errors in
catch (e)statements by default.