Move orchestrator to own module #4699
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89737933. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4699 +/- ##
==========================================
+ Coverage 96.66% 96.68% +0.01%
==========================================
Files 578 580 +2
Lines 60525 60530 +5
==========================================
+ Hits 58508 58521 +13
+ Misses 2017 2009 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: This diff: preliminary cleanup that gets the `Orchestrator` out of `ax/service`, which is generally a misnomer dir and will die once `AxClient` is deprecated. Overall plan: https://docs.google.com/document/d/1OWGOk1bFjjPpGrYxASYNusONQORdtGiThzCrNy30hkM/edit?tab=t.1lbaw27gcn4u {F1984357683} Sorry friends, big diff : | sorrybigdiff But, now we're closer to this clean module organization! {F1984364197} X-link: facebookresearch/Kats#347 Pull Request resolved: facebook#4699 Differential Revision: D89737933
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Kats
that referenced
this pull request
Dec 24, 2025
Summary: This diff: preliminary cleanup that gets the `Orchestrator` out of `ax/service`, which is generally a misnomer dir and will die once `AxClient` is deprecated. Overall plan: https://docs.google.com/document/d/1OWGOk1bFjjPpGrYxASYNusONQORdtGiThzCrNy30hkM/edit?tab=t.1lbaw27gcn4u {F1984357683} Sorry friends, big diff : | sorrybigdiff But, now we're closer to this clean module organization! {F1984364197} Pull Request resolved: facebookresearch#347 X-link: facebook/Ax#4699 Differential Revision: D89737933
lena-kashtelyan
force-pushed
the
export-D89737933
branch
from
a695c75 to
980a61a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff: preliminary cleanup that gets the
Orchestratorout ofax/service, which is generally a misnomer dir and will die onceAxClientis deprecated.Overall plan: https://docs.google.com/document/d/1OWGOk1bFjjPpGrYxASYNusONQORdtGiThzCrNy30hkM/edit?tab=t.1lbaw27gcn4u
{F1984357683}
Differential Revision: D89737933