Move WithDBSettingsBase to sqa_store
#4700
Open
+2,420
−2,359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89749717. |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 24, 2025
Summary: Pull Request resolved: facebook#4700 Same reasoning as in D89737933: `ax/service` was always a misnomer (of my creation, no denying here), time for it to be ready to die once `AxClient` is deprecated! Differential Revision: D89749717 Privacy Context Container: L1307644
lena-kashtelyan
force-pushed
the
export-D89749717
branch
from
8ad72ef to
a78c903
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 24, 2025
Summary: Pull Request resolved: facebook#4700 Same reasoning as in D89737933: `ax/service` was always a misnomer (of my creation, no denying here), time for it to be ready to die once `AxClient` is deprecated! Differential Revision: D89749717 Privacy Context Container: L1307644
lena-kashtelyan
force-pushed
the
export-D89749717
branch
from
a78c903 to
e104fcf
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 24, 2025
Summary: Pull Request resolved: facebook#4700 Same reasoning as in D89737933: `ax/service` was always a misnomer (of my creation, no denying here), time for it to be ready to die once `AxClient` is deprecated! Differential Revision: D89749717 Privacy Context Container: L1307644
lena-kashtelyan
force-pushed
the
export-D89749717
branch
from
e104fcf to
b3d7560
Compare
Differential Revision: D89737933
Summary: Pull Request resolved: facebook#4700 Same reasoning as in D89737933: `ax/service` was always a misnomer (of my creation, no denying here), time for it to be ready to die once `AxClient` is deprecated! Differential Revision: D89749717 Privacy Context Container: L1307644
lena-kashtelyan
force-pushed
the
export-D89749717
branch
from
b3d7560 to
371ef7c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4700 +/- ##
==========================================
+ Coverage 96.66% 96.68% +0.01%
==========================================
Files 578 580 +2
Lines 60525 60530 +5
==========================================
+ Hits 58508 58521 +13
+ Misses 2017 2009 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Same reasoning as in D89737933:
ax/servicewas always a misnomer (of my creation, no denying here), time for it to be ready to die onceAxClientis deprecated!Differential Revision:
D89749717
Privacy Context Container: L1307644