Un-bifurcate gen_single_trial and gen
#4701
Open
+79
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When `gen_single_trial` does not call `gen`, we have a few problems, in order of importance: 1. Forgetting to specify `pending_observations` to `gen_single_trial` will result in no `pending_observations` use. This is different from the behavior in the main `gen`, so it's a huge gotcha and could already be causing silent bugs. 2. Unnecessary bifurcation, meaning that more behaviors like 1) could encroach in the future. 3. Repeated operations. Differential Revision: D80174582 Privacy Context Container: L1307644
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D80174582. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4701 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 580 580
Lines 60714 60741 +27
=======================================
+ Hits 58708 58736 +28
+ Misses 2006 2005 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When
gen_single_trialdoes not callgen, we have a few problems, in order of importance:pending_observationstogen_single_trialwill result in nopending_observationsuse. This is different from the behavior in the maingen, so it's a huge gotcha and could already be causing silent bugs.Differential Revision:
D80174582
Privacy Context Container: L1307644