Remove unused options from observations_from_data #4716
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `Metric.data_constructor` is no longer used following D89689313. Changes: * Remove `Metric.data_constructor` class attribute * Change `Metric.has_map_data` from a property into a class attribute based on whether the metric is a MapMetric The longer-term plan is to allow (and eventually require) all metrics to return `MapData`); instead of checking whether the metric has map data, we should add an attribute `step_should_be_modeled` that tells whether that data is relevant for modeling. This will allow for merging `Metric` and `MapMetric` as well as `Data` and `MapData` Reviewed By: lena-kashtelyan Differential Revision: D89748011
Summary: **Context**: `observations_from_data` is almost never used outside tests after previous refactoring, and most of its arguments are never used. **Changes**: Removes most options from `observations_from_data`, with behavior now matching the previous defaults. Differential Revision: D89823679
|
@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89823679. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4716 +/- ##
==========================================
- Coverage 96.69% 96.69% -0.01%
==========================================
Files 580 580
Lines 60697 60668 -29
==========================================
- Hits 58692 58663 -29
Misses 2005 2005 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 26, 2025
Summary: **Context**: `observations_from_data` is almost never used outside tests after previous refactoring, and most of its arguments are never used. **Changes**: Removes most options from `observations_from_data`, with behavior now matching the previous defaults. Differential Revision: D89823679
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 26, 2025
Summary: **Context**: `observations_from_data` is almost never used outside tests after previous refactoring, and most of its arguments are never used. **Changes**: Removes most options from `observations_from_data`, with behavior now matching the previous defaults. Differential Revision: D89823679
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 29, 2025
Summary: **Context**: `observations_from_data` is almost never used outside tests after previous refactoring, and most of its arguments are never used. **Changes**: Removes most options from `observations_from_data`, with behavior now matching the previous defaults. Reviewed By: lena-kashtelyan Differential Revision: D89823679
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 29, 2025
Summary: **Context**: `observations_from_data` is almost never used outside tests after previous refactoring, and most of its arguments are never used. **Changes**: Removes most options from `observations_from_data`, with behavior now matching the previous defaults. Reviewed By: lena-kashtelyan Differential Revision: D89823679
|
This pull request has been merged in 655d39a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
observations_from_datais almost never used outside tests after previous refactoring, and most of its arguments are never used.Changes: Removes most options from
observations_from_data, with behavior now matching the previous defaults.Differential Revision: D89823679