[RN][iOS] Remove the legacy arch by default #54894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D89276102. |
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-arch-by-default
branch
9 times, most recently
from
8595581 to
c3de3ef
Compare
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-arch-by-default
branch
from
5069423 to
186aab3
Compare
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-arch-by-default
branch
from
186aab3 to
2de95cd
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in c7f433a When will my fix make it into a release? | How to file a pick request? |
|
@cipolleschi merged this pull request in c7f433a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change remove the legacy arch by default from React Native iOS.
Users can still put the code back by using
RCT_REMOVE_LEGACY_ARCH=0 bundle exec pod installChangelog:
[iOS][Breaking] - Remove legacy arch by default
Test Plan:
Tested with RNTester that the app build correctly.
Also verified that the artifacts produced by the prebuilds are smaller than the one built before the change.