Add options for glean indexer #541
Conversation
✅ Deploy Preview for fb-oss-glean canceled.
|
|
Hi @mattwparas! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
OK to merge this. We should de-duplicate the code that also exists in https://github.com/facebookincubator/Glean/blob/main/glean/lang/scip/indexer/Glean/Indexer/SCIP/Main.hs but since that isn't used in the OSS build it'll have to be done by someone on the inside (cc @donsbot ) |
|
Apologies for the delay - I just haven't had the chance to thoroughly test this on my end. I'm happy to merge this as well assuming all looks good there though |
|
@mattwparas there are some build failures |
|
@simonhollis has imported this pull request. If you are a Meta employee, you can view this in D78896896. |
| { scipFile :: FilePath -- ^ input file | ||
| , outputFile :: FilePath -- ^ output file | ||
| , scipLanguage :: Maybe LanguageId -- ^ a default language if known | ||
| , inferLanguage :: Bool -- ^ default False, infer language using file suffix | ||
| , scipPathPrefix :: Maybe FilePath -- ^ optional path to prefix file paths | ||
| , stripPathPrefix :: Maybe FilePath -- ^ optional prefix to drop from paths |
There was a problem hiding this comment.
I'm confused. These are not wired down anywhere? Also I think the renaming of scipIndexFile to scipFile without renaming of usages will break things?
5 participants
Fixes #536