Skip to content

Conversation

@simonmar
Copy link
Collaborator

Just a small fix to remove an unnecessary error.

@netlify
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for fb-oss-glean canceled.

Name Link
🔨 Latest commit a139653
🔍 Latest deploy log https://app.netlify.com/projects/fb-oss-glean/deploys/691c487c42a4450008178577

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2025
@facebook-github-bot
Copy link
Contributor

@CatherineGasnier has imported this pull request. If you are a Meta employee, you can view this in D82812369.

@CatherineGasnier
Copy link

CatherineGasnier commented Sep 19, 2025

I'm confused by github. This has the same commits as #585 + 1, which means in Phabricator it's a massive diff that is redundant with the diff for #586. Not sure what the best way to deal with this is, but probably add the additional commit to #585?

@simonmar
Copy link
Collaborator Author

Yeah sorry I had these stacked in my local repo and github doesn't do stacked PRs very well. Let me unstack this one since it doesn't depend on the earlier commits.

@simonmar
Copy link
Collaborator Author

Also note this is a "draft" PR, I'm trying to keep things in draft until they're ready to import.

@simonmar simonmar marked this pull request as ready for review September 19, 2025 11:51
@simonmar simonmar force-pushed the transform-fix branch 2 times, most recently from 0a12ba5 to 14c9550 Compare November 13, 2025 16:28
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Nov 18, 2025

@jjuliamolin has imported this pull request. If you are a Meta employee, you can view this in D82812369.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants