-
-
Notifications
You must be signed in to change notification settings - Fork 801
💄 Add option for panels to fit to content #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
💄 Add option for panels to fit to content #1096
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Any chances to merge this PR soon? Can someone please restart CI? |
This comment was marked as outdated.
This comment was marked as outdated.
I believe what's missing is test coverage for my new code and logic, which is not my strong suit. I would appreciate any help or suggestions on how to approach writing tests for this. |
This comment was marked as resolved.
This comment was marked as resolved.
📝 Docs previewLast commit 7f9e5a4 at: https://edfd5796.typertiangolo.pages.dev Modified Pages |
|
I updated the PR to remove merge conflicts, and:
Remaining issues:
|
Provide an option for using Rich
Panel.fit()akaPanel(expand=False)for help panels and errors. This was mentioned in discussion #607 and #680. To opt into this new, non-default behavior, just use:I think this can look nicer on very wide terminals, especially for CLIs with few parameters, or short parameter descriptions, so I would prefer to have the option to choose this style sometimes.
Status
Example