ui(editor): add release confirmation dialog to commit modal #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Kapil Gowru <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add release confirmation prompt to commit modal
Updated the "What's next?" modal that appears after committing changes in the Fern Editor. Added a new section with the text "Do you want to release this change now?" below the GitHub link sharing section, with a clickable link that triggers a confirmation dialog.
What was the motivation & context behind this PR?
User requested to add a release prompt to the commit modal UI. When users click the "release this change now" link, they see a confirmation dialog asking "Are you sure?" with "Yes, release" and "No" buttons.
Changes Made
ReleaseConfirmDialogcomponent with confirmation UIEditorNextStepsModalbetween the steps and footerIncomplete Implementation: The
handleReleasefunction currently only logs to console. This needs to be hooked up to actual release functionality before merging, or this should be documented as intentional UI scaffolding.Visual Verification Needed: Please verify the text appears in the correct location (should be in the area highlighted in red in the original request screenshot).
Dialog Behavior: Test that clicking the link shows the confirmation, and both "Yes, release" and "No" buttons work correctly.
How has this PR been tested?
Devin Session: https://app.devin.ai/sessions/0750f8d45c9f4f28a11cad9935bab713
Requested by: Kapil Gowru ([email protected]) - @kgowru