Skip to content

Refactor widget schema handling in Page.php #18373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2025
Merged

Refactor widget schema handling in Page.php #18373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2256a77
Refactor widget schema handling in Page.php
iAmKevinMcKee Oct 31, 2025
a272143
cache widget schema components
danharrin Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/panels/src/Pages/Dashboard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,6 @@ public function getFiltersFormContentComponent(): Component
public function getWidgetsContentComponent(): Component
{
return Grid::make($this->getColumns())
->schema($this->getWidgetsSchemaComponents($this->getWidgets()));
->schema(fn (): array => $this->getWidgetsSchemaComponents($this->getWidgets()));
}
}
18 changes: 14 additions & 4 deletions packages/panels/src/Pages/Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,16 @@ abstract class Page extends BasePage

protected static bool $shouldRegisterNavigation = true;

/**
* @var array<Component | Action | ActionGroup>
*/
protected array $cachedHeaderWidgetsSchemaComponents;

/**
* @var array<Component | Action | ActionGroup>
*/
protected array $cachedFooterWidgetsSchemaComponents;

protected string $view = 'filament-panels::pages.page';

public function getLayout(): string
Expand Down Expand Up @@ -387,10 +397,10 @@ public function headerWidgets(Schema $schema): Schema
->components([
RenderHook::make(PanelsRenderHook::PAGE_HEADER_WIDGETS_START),
Grid::make($this->getHeaderWidgetsColumns())
->schema($widgets = $this->getWidgetsSchemaComponents($this->getHeaderWidgets())),
->schema(fn (): array => $this->cachedHeaderWidgetsSchemaComponents ??= $this->getWidgetsSchemaComponents($this->getHeaderWidgets())),
RenderHook::make(PanelsRenderHook::PAGE_HEADER_WIDGETS_END),
])
->hidden(empty($widgets));
->hidden(fn (): bool => empty($this->cachedHeaderWidgetsSchemaComponents ??= $this->getWidgetsSchemaComponents($this->getHeaderWidgets())));
}

public function footerWidgets(Schema $schema): Schema
Expand All @@ -399,10 +409,10 @@ public function footerWidgets(Schema $schema): Schema
->components([
RenderHook::make(PanelsRenderHook::PAGE_FOOTER_WIDGETS_START),
Grid::make($this->getFooterWidgetsColumns())
->schema($widgets = $this->getWidgetsSchemaComponents($this->getFooterWidgets())),
->schema(fn (): array => $this->cachedFooterWidgetsSchemaComponents ??= $this->getWidgetsSchemaComponents($this->getFooterWidgets())),
RenderHook::make(PanelsRenderHook::PAGE_FOOTER_WIDGETS_END),
])
->hidden(empty($widgets));
->hidden(fn (): bool => empty($this->cachedFooterWidgetsSchemaComponents ??= $this->getWidgetsSchemaComponents($this->getFooterWidgets())));
}

public function getDefaultTestingSchemaName(): ?string
Expand Down
Loading