Skip to content

[FCM] Fix app launch crash #15559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[FCM] Fix app launch crash #15559

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42da0bd
[FCM] Fix app launch crash
paulb777 Nov 29, 2025
2ba15c0
changelog
paulb777 Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 46 additions & 37 deletions FirebaseMessaging/Sources/FIRMessagingRmqManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,53 +493,62 @@ - (void)openDatabase {
dispatch_async(_databaseOperationQueue, ^{
NSFileManager *fileManager = [NSFileManager defaultManager];
NSString *path = [self pathForDatabase];

BOOL didOpenDatabase = YES;
if (![fileManager fileExistsAtPath:path]) {
// We've to separate between different versions here because of backward compatibility issues.
int flags = SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE;
BOOL fileExists = [fileManager fileExistsAtPath:path];

// Ensure the directory exists before trying to create the database if the file doesn't exist.
if (!fileExists) {
NSString *directory = [path stringByDeletingLastPathComponent];
if (![fileManager fileExistsAtPath:directory]) {
NSError *error;
if (![fileManager createDirectoryAtPath:directory
withIntermediateDirectories:YES
attributes:nil
error:&error]) {
NSString *errorMessage = [NSString
stringWithFormat:@"Could not create RMQ database directory at path %@, error: %@",
directory, error];
FIRMessagingLoggerError(kFIRMessagingMessageCodeRmq2PersistentStoreErrorCreatingDatabase,
@"%@", errorMessage);
NSAssert(NO, errorMessage);
return;
}
}
}
int flags = SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE;
#ifdef SQLITE_OPEN_FILEPROTECTION_NONE
flags |= SQLITE_OPEN_FILEPROTECTION_NONE;
flags |= SQLITE_OPEN_FILEPROTECTION_NONE;
#endif
int result = sqlite3_open_v2([path UTF8String], &self -> _database, flags, NULL);
if (result != SQLITE_OK) {
NSString *errorString = FIRMessagingStringFromSQLiteResult(result);
NSString *errorMessage = [NSString
stringWithFormat:@"Could not open existing RMQ database at path %@, error: %@", path,
errorString];
FIRMessagingLoggerError(kFIRMessagingMessageCodeRmq2PersistentStoreErrorOpeningDatabase,
@"%@", errorMessage);
NSAssert(NO, errorMessage);
return;
int result = sqlite3_open_v2([path UTF8String], &self -> _database, flags, NULL);
if (result != SQLITE_OK) {
NSString *errorString = FIRMessagingStringFromSQLiteResult(result);
NSString *errorMessage =
[NSString stringWithFormat:@"Could not open or create RMQ database at path %@, error: %@",
path, errorString];
FIRMessagingLoggerError(kFIRMessagingMessageCodeRmq2PersistentStoreErrorOpeningDatabase,
@"%@", errorMessage);

// If the file existed, it might be corrupt. Let's remove it and fail.
if (fileExists) {
// This is synchronous, but it's on the database queue, so it's safe.
[[NSFileManager defaultManager] removeItemAtPath:path error:nil];
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

It's good practice to handle the error that can occur when removing the item at the specified path. While the NSAssert will likely crash the app in debug builds, logging the error from removeItemAtPath:error: can provide valuable diagnostic information, especially in release builds where assertions are disabled and the app might attempt to recover on the next launch.

        NSError *removeError = nil;
        if (![[NSFileManager defaultManager] removeItemAtPath:path error:&removeError]) {
          FIRMessagingLoggerError(kFIRMessagingMessageCodeRmq2PersistentStoreErrorOpeningDatabase,
                                  @"Failed to remove corrupt database file at %@: %@", path,
                                  removeError);
        }

}
NSAssert(NO, errorMessage);
return;
}

if (!fileExists) {
// New database, create tables.
[self createTableWithName:kTableOutgoingRmqMessages command:kCreateTableOutgoingRmqMessages];

[self createTableWithName:kTableLastRmqId command:kCreateTableLastRmqId];
[self createTableWithName:kTableS2DRmqIds command:kCreateTableS2DRmqIds];
} else {
// Calling sqlite3_open should create the database, since the file doesn't exist.
int flags = SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE;
#ifdef SQLITE_OPEN_FILEPROTECTION_NONE
flags |= SQLITE_OPEN_FILEPROTECTION_NONE;
#endif
int result = sqlite3_open_v2([path UTF8String], &self -> _database, flags, NULL);
if (result != SQLITE_OK) {
NSString *errorString = FIRMessagingStringFromSQLiteResult(result);
NSString *errorMessage =
[NSString stringWithFormat:@"Could not create RMQ database at path %@, error: %@", path,
errorString];
FIRMessagingLoggerError(kFIRMessagingMessageCodeRmq2PersistentStoreErrorCreatingDatabase,
@"%@", errorMessage);
NSAssert(NO, errorMessage);
Comment on lines -528 to -533
Copy link
Member

@ncooke3 ncooke3 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More investigation needed. Converted to draft.

From linked issue:

Fatal Exception: NSInternalInconsistencyException
Could not create RMQ database at path /var/mobile/Containers/Data/Application/372D4296-3F35-46FD-B3C9-0A20877B8378/Library/Application Support/Google/FirebaseMessaging/rmq2.sqlite, error: 14 - unable to open database file

This highlighted else clause is where the execution flow reaches the assertion. The assertion's error message is only used here. Entering the else clause means database path exists, so the error has to do with opening a database we know exists in the filesystem.

didOpenDatabase = NO;
} else {
[self updateDBWithStringRmqID];
}
// Existing database, update schema if needed.
[self updateDBWithStringRmqID];
}

if (didOpenDatabase) {
[self createTableWithName:kTableSyncMessages command:kCreateTableSyncMessages];
}
// This table should exist in both new and old databases.
[self createTableWithName:kTableSyncMessages command:kCreateTableSyncMessages];
});
}

Expand Down
Loading