[Infra] Remove -sdk flag from xcodebuild in build.sh
#15565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewheard
changed the title
-sdk flag from xcodebuild commands in build.sh-sdk flag from xcodebuild in build.sh
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the explicit -sdk flag from xcodebuild commands in the build.sh script. As explained in the description, this is a necessary change to support Swift macros, as it allows xcodebuild to correctly infer the target SDK based on the -destination flag. The change is logical and well-implemented. I've only added one minor suggestion to fix an indentation inconsistency for better code style.
ncooke3
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
build.shwe always provide a specific-destination, which allowsxcodebuildto automatically infer the correct-sdk. Removing-sdkallows us to support Swift macros, which need different SDKs for the host and library.Context: Swift macros run on the build host (i.e., macOS) to expand code but specifying
-sdk 'iphonesimulator'(or any other SDK) results in the compiler attempting to build the macro for iOS where they aren't supported. Removing the flag allows Xcode to infer macOS for the macro and iOS for the library target based on the-destination.#no-changelog