Update FirebaseTelemetry react function to take app

[tonybaroneee]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3a8ed33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @tonybaroneee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the FirebaseTelemetry React component to enhance clarity and control over Firebase application integration. Instead of handling Firebase app initialization internally via firebaseOptions, the component now explicitly requires an already initialized FirebaseApp instance to be passed as a prop. This modification streamlines the component's API, making it more predictable and aligning its behavior with common React patterns for managing external dependencies. The changes include updates to the component's signature, internal logic, and corresponding documentation and test cases.

Highlights

• API Change: The FirebaseTelemetry React function now accepts a FirebaseApp instance directly as a prop, instead of FirebaseOptions.
• Simplified Usage: This change removes the component's internal logic for initializing or retrieving a Firebase app, making its dependency explicit and simplifying its usage.
• Documentation and Tests Updated: All relevant documentation and test files have been updated to reflect the new firebaseApp prop and its required usage.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the FirebaseTelemetry React component to accept a FirebaseApp instance directly, rather than FirebaseOptions. This is a great improvement that promotes consistency by using a single app instance and avoids re-initializing Firebase apps within the component. The changes have been applied consistently across the implementation, tests, and documentation files. I have one suggestion to improve the robustness and efficiency of the error handling within the useEffect hook.

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (3611531) and merge commit (612d7c2).

Test Logs

• Base (3611531): https://github.com/firebase/firebase-js-sdk/actions/runs/19872610105
• Merge (612d7c2): https://github.com/firebase/firebase-js-sdk/actions/runs/19896538517

1. https://storage.googleapis.com/firebase-sdk-metric-reports/c39txZbWrk.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

No changes between base commit (3611531) and merge commit (612d7c2).

Test Logs

• Base (3611531): https://github.com/firebase/firebase-js-sdk/actions/runs/19872610105
• Merge (612d7c2): https://github.com/firebase/firebase-js-sdk/actions/runs/19896538517

1. https://storage.googleapis.com/firebase-sdk-metric-reports/6x7fnyiZsy.html