feat(functions): avoid blocking on missing v2 source tokens

[kdawgwilk]

Add an optional timeout to SourceTokenScraper so callers can bail out when a
source token never returns. Use a 2s cap in v2 create/update paths to keep
builds running in parallel, while still reusing tokens when available. Add a
spec covering the timeout behavior.

[gemini-code-assist]

Summary of Changes

Hello @kdawgwilk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of Google Cloud Functions v2 deployments by preventing indefinite blocking when the backend fails to return a source token. It introduces a timeout mechanism to the SourceTokenScraper, ensuring that deployment processes can continue without waiting indefinitely, thereby improving overall build efficiency and resilience against transient backend issues.

Highlights

• Timeout for SourceTokenScraper: An optional timeoutMs parameter has been added to the SourceTokenScraper's getToken method, allowing callers to specify a maximum waiting time for a source token before proceeding.
• GCFv2 Deployment Resilience: A 2-second timeout (SOURCE_TOKEN_FETCH_TIMEOUT_MS) is now applied to getToken calls during Google Cloud Functions v2 creation and update processes, preventing builds from blocking indefinitely if a source token is not returned promptly.
• Timeout Logic Implementation: A new private helper method, waitForToken, has been introduced within SourceTokenScraper to manage the timeout logic using Promise.race, ensuring efficient handling of token fetching.
• New Test Coverage: A new test case has been added to sourceTokenScraper.spec.ts to specifically validate the early return behavior of getToken when a timeout is configured, ensuring the functionality works as expected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a timeout mechanism to the SourceTokenScraper to prevent deployments from getting stuck when a source token isn't returned by the backend. This is a valuable improvement for deployment reliability. The implementation correctly uses Promise.race for the timeout and applies it to GCFv2 function creation and updates. The added test case effectively validates the new timeout behavior. I have one suggestion to improve code maintainability by reducing some duplication.

[kdawgwilk]

Anything i can do here to move this forward?