BREAKING: Enforce strict timeout validation for functions

[taeold]

Function deploy will now enforce strict timeout validation.

This change ensures that function timeouts do not exceed the maximum allowed limits for their respective trigger types, preventing potential issues like infinite retry loops and confusing timeouts.

We will update the precise quota for each trigger type in https://firebase.google.com/docs/functions/quotas

[gemini-code-assist]

Summary of Changes

Hello @taeold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical breaking change by enforcing strict timeout validation for functions during deployment. The primary goal is to enhance the reliability and predictability of function execution by ensuring that all configured timeouts adhere to the maximum limits set for their specific trigger types. This prevents common pitfalls like functions running indefinitely or encountering unexpected timeout errors due to misconfigurations.

Highlights

• Strict Timeout Validation: Implemented strict validation for function timeouts during deployment to ensure they do not exceed maximum allowed limits based on their trigger type.
• Prevents Issues: This validation aims to prevent potential problems such as infinite retry loops and confusing timeout behaviors, enhancing function reliability.
• Trigger-Specific Limits: New timeout limits are enforced based on the function's platform and trigger type, including HTTP, Event, Scheduled, Task Queue, and Gen 1 functions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces strict timeout validation for functions, which is a valuable addition to prevent misconfigurations. The implementation is solid, and the new tests are comprehensive. I've identified a redundant function call that should be removed and an opportunity to refactor a new function to improve its maintainability by removing duplicated logic. Overall, these are great changes.