Add test for use command

[joehan]

Description

Going through my usual exercise of trying out new AI by having it write unit tests - this time, AGY wrote tests for the use command.

This is part of a larger effort to increase the test coverage for this repo.

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new suite of unit tests for the use command's setNewActive function. The tests ensure the correct behavior of setting active projects, handling aliases, and managing error conditions, thereby improving the robustness and reliability of the command. This is part of an ongoing effort to enhance the project's test coverage.

Highlights

• New Test File: A new test file, "src/commands/use.spec.ts", has been added to the codebase.
• Unit Tests for use Command: Comprehensive unit tests have been introduced for the setNewActive function within the use command module.
• Covered Scenarios: The tests validate various scenarios including setting active projects by alias, by project ID, creating new aliases, and proper error handling for invalid project selections.
• Increased Test Coverage: This pull request significantly contributes to increasing the overall test coverage for the repository, specifically targeting the use command.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds unit tests for the use command, which is a great step towards improving test coverage. The tests cover the basic functionality of setNewActive well. I've added one suggestion for an additional test case that covers a more complex scenario of creating an alias when the project is specified by an existing alias. This new test would help ensure more robust behavior and appears to uncover a latent bug.

[gemini-code-assist]

The test suite is a great start! To make it more robust, I suggest adding a test case for creating a new alias when the project is specified by an existing alias. This would cover a more complex user scenario and could reveal a potential issue where a new alias points to an existing alias instead of the underlying project ID.

With the current implementation of setNewActive, the suggested test below would likely fail. The new alias (staging) would point to the existing alias (prod) instead of the underlying project ID (project-id), because setNewActive uses projectOrAlias instead of the resolved project ID when creating the new alias.

    });

    it("should create a new alias that points to the project ID, not to the existing alias", async () => {
      rc.addProjectAlias("prod", "project-id");
      getProjectStub.resolves({ projectId: "project-id" });

      await setNewActive("prod", "staging", rc, "root");

      expect(rc.resolveAlias("staging")).to.equal("project-id");
      expect(makeActiveProjectStub.calledWith("root", "prod")).to.be.true;
    });