Skip to content

Add Add/Update behavior and change default behavior #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add Add/Update behavior and change default behavior #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Model/Config/Source/Behavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ public function toOptionArray()
{
if (!$this->_options) {
$this->_options = [
['value' => \Magento\ImportExport\Model\Import::BEHAVIOR_APPEND, 'label' => __('Add/Update')],
['value' => \Magento\ImportExport\Model\Import::BEHAVIOR_REPLACE, 'label' => __('Replace')],
['value' => \Magento\ImportExport\Model\Import::BEHAVIOR_APPEND, 'label' => __('Append')],
['value' => \Magento\ImportExport\Model\Import::BEHAVIOR_ADD_UPDATE, 'label' => __('Add/Update')],
['value' => \Magento\ImportExport\Model\Import::BEHAVIOR_REPLACE, 'label' => __('Replace')],
['value' => \Magento\ImportExport\Model\Import::BEHAVIOR_DELETE, 'label' => __('Delete')],
];
}
Expand Down
2 changes: 1 addition & 1 deletion etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<fastsimpleimport>
<default>
<ignore_duplicates>0</ignore_duplicates>
<behavior>append</behavior>
<behavior>add_update</behavior>
Copy link
Member

@sprankhub sprankhub Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. To be honest, I am not sure if we should do this.

Copy link
Member

@avstudnitz avstudnitz Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. No, I wouldn't change the default behavior - we'd need to introduce a 2.0 then, and I don't think that would be worth it.
Everything else in this PR looks good for me.

<entity>catalog_product</entity>
<validation_strategy>validation-stop-on-errors</validation_strategy>
<allowed_error_count>10</allowed_error_count>
Expand Down