Skip to content

Conversation

@DavideIadeluca
Copy link
Contributor

Prepares https://github.com/flarum/framework/milestone/44

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title chore(core): bump app version [1.x] chore(core): bump app version Feb 18, 2025
@DavideIadeluca DavideIadeluca marked this pull request as ready for review February 18, 2025 11:32
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner February 18, 2025 11:32
@luceos
Copy link
Member

luceos commented Feb 18, 2025

We actually have a whole checklist to follow for releases. If you're going to contribute to releases, it would probably be time to look into getting you access to that. cc @imorland @SychO9 and @GreXXL .

@DavideIadeluca DavideIadeluca marked this pull request as draft February 18, 2025 20:00
@imorland imorland marked this pull request as ready for review March 11, 2025 18:09
@imorland imorland merged commit 2bc42a0 into flarum:1.x Mar 11, 2025
322 checks passed
@imorland imorland deleted the di/1810 branch March 11, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants