Skip to content

Conversation

@DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented May 23, 2025

Fixes #0000
relates to #4216

Changes proposed in this pull request:

  • Allow to translate validation attributes of tags

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review May 23, 2025 15:30
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner May 23, 2025 15:30
@imorland imorland added this to the 1.8.11 milestone Aug 20, 2025
@imorland imorland merged commit 593b9cf into flarum:1.x Oct 3, 2025
321 checks passed
@imorland imorland deleted the di/tags-validation-attributes branch October 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants