Skip to content

Conversation

@imorland
Copy link
Member

@imorland imorland commented Oct 2, 2025

We currently assume that we will always be the source of truth for canonical URL setting. If a 3rd party extension needed to set a different canonical URL for any reason, this would then be overwritten. This change aims to accept pre-setting the canonical.

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland added this to the 1.8.11 milestone Oct 2, 2025
@imorland imorland requested a review from a team as a code owner October 2, 2025 17:31
@imorland imorland merged commit 6141e5e into 1.x Oct 3, 2025
697 of 706 checks passed
@imorland imorland deleted the im/canonical branch October 3, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants