-
Notifications
You must be signed in to change notification settings - Fork 75
chore(op-alloy): Update to use op-alloy flashblock types #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates from custom flashblock type definitions to official op-alloy flashblock types, aligning with similar changes already made in reth. The migration removes local primitive definitions and replaces them with types from the op-alloy-rpc-types-engine crate.
Key changes:
- Updated op-alloy dependencies from 0.22.0 to 0.22.3
- Removed custom
ExecutionPayloadBaseV1,ExecutionPayloadFlashblockDeltaV1, andFlashblocksPayloadV1types - Replaced custom types with
OpFlashblockPayloadBase,OpFlashblockPayloadDelta, andOpFlashblockPayloadfrom op-alloy - Updated metadata handling to use
OpFlashblockPayloadMetadatawith typedBTreeMapfields instead of string-basedHashMap
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rollup-boost/src/flashblocks/primitives.rs | Deleted entire file containing custom primitive definitions |
| crates/rollup-boost/src/flashblocks/service.rs | Updated type references from custom types to op-alloy types |
| crates/rollup-boost/src/flashblocks/outbound.rs | Updated WebSocket publisher to use OpFlashblockPayload type |
| crates/rollup-boost/src/flashblocks/inbound.rs | Updated receiver service to use OpFlashblockPayload type |
| crates/rollup-boost/src/flashblocks/mod.rs | Removed exports of deleted primitives module |
| crates/flashblocks-rpc/src/flashblocks.rs | Updated flashblocks overlay to use OpFlashblockPayload type |
| crates/flashblocks-rpc/src/cache.rs | Added receipt conversion function and updated metadata handling to use typed maps |
| crates/flashblocks-rpc/src/tests/mod.rs | Updated test fixtures to use new op-alloy types with typed metadata fields |
| crates/flashblocks-rpc/Cargo.toml | Added op-alloy-rpc-types-engine dependency |
| Cargo.toml | Updated op-alloy dependencies to version 0.22.3 |
| Cargo.lock | Updated dependency versions and transitive dependencies |
| Justfile | Added new convenience commands for clippy, fmt, and test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
df8f5b6 to
50d3ee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Same comment as in op-rbuilder |
Update to use op-alloy flashblock types.