Skip to content

Conversation

@0x00101010
Copy link
Contributor

@0x00101010 0x00101010 commented Nov 20, 2025

Copilot AI review requested due to automatic review settings November 20, 2025 04:47
@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rollup-boost Ignored Ignored Preview Nov 20, 2025 4:56am

Copilot finished reviewing on behalf of 0x00101010 November 20, 2025 04:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from custom flashblock type definitions to official op-alloy flashblock types, aligning with similar changes already made in reth. The migration removes local primitive definitions and replaces them with types from the op-alloy-rpc-types-engine crate.

Key changes:

  • Updated op-alloy dependencies from 0.22.0 to 0.22.3
  • Removed custom ExecutionPayloadBaseV1, ExecutionPayloadFlashblockDeltaV1, and FlashblocksPayloadV1 types
  • Replaced custom types with OpFlashblockPayloadBase, OpFlashblockPayloadDelta, and OpFlashblockPayload from op-alloy
  • Updated metadata handling to use OpFlashblockPayloadMetadata with typed BTreeMap fields instead of string-based HashMap

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/rollup-boost/src/flashblocks/primitives.rs Deleted entire file containing custom primitive definitions
crates/rollup-boost/src/flashblocks/service.rs Updated type references from custom types to op-alloy types
crates/rollup-boost/src/flashblocks/outbound.rs Updated WebSocket publisher to use OpFlashblockPayload type
crates/rollup-boost/src/flashblocks/inbound.rs Updated receiver service to use OpFlashblockPayload type
crates/rollup-boost/src/flashblocks/mod.rs Removed exports of deleted primitives module
crates/flashblocks-rpc/src/flashblocks.rs Updated flashblocks overlay to use OpFlashblockPayload type
crates/flashblocks-rpc/src/cache.rs Added receipt conversion function and updated metadata handling to use typed maps
crates/flashblocks-rpc/src/tests/mod.rs Updated test fixtures to use new op-alloy types with typed metadata fields
crates/flashblocks-rpc/Cargo.toml Added op-alloy-rpc-types-engine dependency
Cargo.toml Updated op-alloy dependencies to version 0.22.3
Cargo.lock Updated dependency versions and transitive dependencies
Justfile Added new convenience commands for clippy, fmt, and test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 20, 2025 04:56
Copilot finished reviewing on behalf of 0x00101010 November 20, 2025 04:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SozinM
Copy link
Collaborator

SozinM commented Nov 20, 2025

Same comment as in op-rbuilder
flashbots/op-rbuilder#328 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants