-
Notifications
You must be signed in to change notification settings - Fork 544
Updated fwd input plugin for fixing user auth, added 1 missing config option and general cleanup to doc. Fixes #2212. #2230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…g option and general cleanup to doc. Fixes #2212. Signed-off-by: Eric D. Schabell <[email protected]>
|
Warning Rate limit exceeded@eschabell has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 12 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughDocumentation for the Forward input plugin was updated to standardize configuration parameter names from CamelCase to snake_case, restructure authentication guidance into warning blocks, and add detailed user authentication examples with the empty_shared_key parameter. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Waiting.... Rate limit exceeded |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
pipeline/inputs/forward.md (1)
143-187: Newempty_shared_keyexamples are well-structured and consistent.The YAML and .conf examples in this new section demonstrate the feature appropriately. However, the
.confexamples (lines 170-184) continue to use PascalCase naming (Security.Users,Empty_Shared_Key,Self_Hostname), which conflicts with the snake_case names in the parameter table above.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/inputs/forward.md(3 hunks)
🔇 Additional comments (2)
pipeline/inputs/forward.md (2)
93-98: Well-structured authentication requirement warning.The warning block clearly communicates the requirement that
security.usersmust be paired with eithershared_keyorempty_shared_key. This directly addresses the authentication issues mentioned in the PR objectives and helps prevent misconfiguration.
13-13: Documentation for newempty_shared_keyparameter is clear and useful.The parameter description and the dedicated section (lines 143-187) with practical examples effectively document how to use user authentication without requiring a shared key. This addresses the missing configuration option mentioned in the PR objectives.
Signed-off-by: Eric D. Schabell <[email protected]>
|
AI review passed, merging. |
Updated fwd input plugin for fixing user auth, added 1 missing config option and general cleanup to doc. Fixes #2212.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.