-
Notifications
You must be signed in to change notification settings - Fork 544
Fixed typos, sorted config table, moved a config option from metrics table. Fixes #2233 #2234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Eric D. Schabell <[email protected]>
…table. Fixes #2233. Signed-off-by: Eric D. Schabell <[email protected]>
WalkthroughThis PR updates the CPU metrics input plugin documentation: parameter names standardized to lowercase, the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pipeline/inputs/cpu-metrics.md (1)
35-35: Minor style: Streamline verbose phrase (optional).The phrase "In order to get the statistics" could be simplified to "To get the statistics" for better conciseness.
-In order to get the statistics of the CPU usage of your system, you can run the plugin from the command line or through the configuration file: +To get the statistics of the CPU usage of your system, you can run the plugin from the command line or through the configuration file:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pipeline/inputs/cpu-metrics.md(1 hunks)vale-styles/FluentBit/Acronyms.yml(1 hunks)
🧰 Additional context used
🪛 LanguageTool
pipeline/inputs/cpu-metrics.md
[style] ~35-~35: Consider a more concise word here.
Context: ... | false | ## Get started In order to get the statistics of the CPU usage of ...
(IN_ORDER_TO_PREMIUM)
🔇 Additional comments (5)
vale-styles/FluentBit/Acronyms.yml (1)
102-102: Acronym exception addition is correct.The addition of PID to the exceptions list is appropriately positioned alphabetically and aligns with the lowercase
pidparameter naming convention being introduced in the CPU metrics documentation.pipeline/inputs/cpu-metrics.md (4)
13-13: Main CPU table documentation is consistent.The
user_pkey documentation aligns with the plugin's output examples and provides consistent context for system-wide CPU usage metrics.
21-21: Per-core keys table is now complete.Adding
cpuN.p_userdocumentation completes the set of documented per-core metrics and aligns with the output examples showing per-core user mode CPU usage.
27-32: Configuration table reorganization is correct and well-structured.The table now properly:
- Uses lowercase parameter naming convention (e.g.,
interval_secinstead ofInterval_Sec), which aligns with YAML configuration syntax and the Vale acronym exception just added- Moves the
threadedparameter from an incorrect placement in the metrics table to its proper location in the configuration section, addressing issue #2233- Maintains alphabetical ordering of parameters
- Provides clear descriptions with appropriate references (e.g., link to multithreading documentation)
40-40: Terminology update improves clarity.Changing the description to reference "input plugin" rather than "filter" is more accurate and aligns with Fluent Bit's architectural terminology.
Signed-off-by: Eric D. Schabell <[email protected]>
|
AI review passed, merging. |
Fixed typos, sorted config table, moved a config option from metrics table. Fixes #2233
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.