Resolve #2074 #3848
Open
Resolve #2074 #3848
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
cptartur
force-pushed
the
spr/master/b701265d
branch
from
f3341f3 to
975c55c
Compare
Open
cptartur
force-pushed
the
spr/master/adef9534
branch
from
6aabc54 to
d1cf4c1
Compare
cptartur
force-pushed
the
spr/master/b701265d
branch
from
975c55c to
b529f57
Compare
This was referenced Nov 7, 2025
cptartur
force-pushed
the
spr/master/adef9534
branch
from
d1cf4c1 to
c796ac7
Compare
cptartur
force-pushed
the
spr/master/b701265d
branch
from
b529f57 to
a5347c6
Compare
cptartur
force-pushed
the
spr/master/adef9534
branch
from
c796ac7 to
6fecbf4
Compare
cptartur
force-pushed
the
spr/master/b701265d
branch
2 times, most recently
from
275f396 to
12fa2fe
Compare
cptartur
force-pushed
the
spr/master/adef9534
branch
from
6fecbf4 to
0560da2
Compare
cptartur
requested review from
franciszekjob and
ksew1
and removed request for
a team
ksew1
reviewed
Nov 11, 2025
| let path = entry.path(); | ||
|
|
||
| if path.is_file() { | ||
| if path.is_file() && path.extension().is_some_and(|ex| ex == "cairo") { |
Member
There was a problem hiding this comment.
The issue says you should replace on cairo.template and here you are doing on .cairo
Member
Author
There was a problem hiding this comment.
Right, I don't think we want to bother with cairo.template. I extended the logic so it checks for .cairo files (replacing all files broke some tests).
The improvement with templates file is only theoretical + it will break ls support for them (unless they support .template explicitly) so it's not improving anything for our tests DevX.
Contributor
franciszekjob
left a comment
franciszekjob
left a comment
There was a problem hiding this comment.
Same remark as Karol
cptartur
force-pushed
the
spr/master/b701265d
branch
from
12fa2fe to
f955261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2074
Stack:
RawFeltVec#3849