Validate snfoundry.toml #3869
Open
Validate snfoundry.toml #3869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
changed the base branch from
master
to
fix-native-meta-tx-v0-tests
franciszekjob
requested review from
MKowalski8 and
cptartur
and removed request for
a team
cptartur
requested changes
Oct 31, 2025
franciszekjob
commented
Nov 5, 2025
cptartur
approved these changes
Nov 5, 2025
cptartur
requested changes
Nov 5, 2025
… into 3811-fix-parsing-snfoundry-toml
cptartur
reviewed
Nov 6, 2025
Comment on lines
-53
to
-55
| core::load_config( | ||
| raw_config_json, | ||
| profile.map_or_else(|| Profile::Default, |p| Profile::Some(p.to_string())), |
Member
There was a problem hiding this comment.
This code was specifically refactored so that load_config can actually be shared between this top level function and forge which uses it directly.
If we cannot share logic between cast and forge at all, let's get rid of core::load_config entirely and use the primitives from core directly in forge logic.
| profile: Option<&str>, | ||
| ) -> Result<T> { | ||
| let config_path = path | ||
| pub fn load_config<T>(path: Option<&Utf8PathBuf>, profile: Option<&str>) -> Result<T> |
Member
There was a problem hiding this comment.
Maybe rename this something it suggests more it's loading form snfoundry_toml?
| use std::env; | ||
|
|
||
| fn resolve_env_variables(config: serde_json::Value) -> anyhow::Result<serde_json::Value> { | ||
| pub fn resolve_env_variables(config: serde_json::Value) -> anyhow::Result<serde_json::Value> { |
Member
There was a problem hiding this comment.
Suggested change
| pub fn resolve_env_variables(config: serde_json::Value) -> anyhow::Result<serde_json::Value> { | |
| pub(crate) fn resolve_env_variables(config: serde_json::Value) -> anyhow::Result<serde_json::Value> { |
If you need this in other modules pub is okay, but if it remains just for uses in this crate, let's not publish it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3811
Introduced changes
Checklist
CHANGELOG.md