Adds ability to configure default config path #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though Litestream::Commands methods allow for passing a --config option for the config path, helper methods like Litestream.verify!, which wraps Litestream::Commands.databases and the Puma plugin, which wraps Litestream::Commands.replicate, do not. This changeset adds the ability to configure an application-wide default for the litestream config path allows for use of features like Litestream.verify! and the Puma plugin without otherwise having to modify these features to accept the --config option.
Contributor
|
@fractaledmind I'm running litestream-ruby on various environments (e.g. staging), the ability to specify the config would go a long way! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Litestream Ruby config path defaults to
"config/litestream.yml". Some applications may wish to use a custom configuration path, say, one that is based on the Rails environment"config/litestream/#{Rails.env}.yml"Though
Litestream::Commandsmethods allow for passing a--configoption for the config path, helper methods likeLitestream.verify!, which wrapsLitestream::Commands.databasesand the Puma plugin, which wrapsLitestream::Commands.replicate, do not.This changeset adds the ability to configure an application-wide default for the litestream config path allows for use of features like
Litestream.verify!and the Puma plugin without otherwise having to modify these features to accept the--configoption.