Skip to content

Conversation

@phiamo
Copy link

@phiamo phiamo commented Mar 16, 2020

  • Bump react deps to 1.1.* (@phiamo)
  • combined the in 0.6.0 existing ReadableStream and WritableStream
    into the now also final InputStream and OutputStream classes
  • adapted the cancelTimer API change in Client

All Unit tests are green!

Copy link
Contributor

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phiamo Thanks for looking into this! Looks good to me overall, only added some minor remarks below :shipit:

@phiamo
Copy link
Author

phiamo commented Nov 8, 2020

just saw i resolved your comments a while ago @clue

@clue
Copy link
Contributor

clue commented Jan 25, 2021

@phiamo Thanks for the update!

Can you look into the failing test cases? I haven't looked into this yet, but it looks like this did work previously (as of #54)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants