-
Notifications
You must be signed in to change notification settings - Fork 39
WIP: Feature/role system #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shawnthompson
wants to merge
11
commits into
gc-da11yn:main
Choose a base branch
from
shawnthompson:feature/role-system
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comprehensive roles.js with W3C ARRM role definitions - Add rolePairs.js for role page generation - Add groupPairsEn.js and groupPairsFr.js for role group organization - Define 13 accessibility roles across 4 role groups - Include bilingual role labels and detailed job descriptions
- Update .eleventy.js with role filtering functions (byRole, byAnyRole) - Add role-group-sections.njk partial for displaying role groups - Add role-mini-toc.njk partial for role navigation - Enable role-based content filtering across the site
- Add role.njk templates for individual role pages (English/French) - Add roles-group.njk templates for role group pages - Add roles/index.njk landing pages with role filtering interface - Include W3C ARRM role descriptions and job titles - Enable bilingual role-based content discovery
- Add role column to pageListTable.njk with badge display - Update pageLabel.njk to show role badges for content - Enhance breadcrumbs.njk with role-based navigation - Update base layout to include role system CSS and JavaScript - Modify tagList.js to include role and roleGroup tags - Enable visual role identification across all pages
✅ Deploy Preview for a11ycanada ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
88dd896 to
3a0456a
Compare
- Add role tags to 166+ content pages across English and French - Tag navigation pages with appropriate roles (governance, etc.) - Tag content pages by role: contentAuthoring, uxDesign, qaAutomated, etc. - Tag Microsoft Office guides, accessibility standards, and how-to content - Ensure bilingual parity with equal role coverage (83 EN + 83 FR files) - Enable role-based content filtering and discovery across entire site
- Convert tag labels from Title Case to sentence case for consistency - Add 'roles' entries for both English and French subjects
2 tasks
Contributor
Author
|
Thanks to @zookelvin for the help tagging the pages in this PR. |
Closed
3a0456a to
8800862
Compare
- Add CSV download functionality to page list table - Implement git creation dates in CSV exports using computed data - Add new columns: Layout, Date Modified, Date Created, Content Type - Fix Nunjucks template syntax issues with conditional blocks
- Remove blank lines at top of CSV files using Nunjucks whitespace control - Add UTF-8 BOM transform for proper French accent encoding in Excel - Translate content type values in French CSV from English to French: - 'Landing Page' → 'Page d'atterrissage' - 'Content Page' → 'Page de contenu' - 'Link' → 'Lien' This ensures both English and French CSV exports work correctly with proper encoding and localized content.
- Create shared content type macro in src/_includes/macros/contentType.njk - Update HTML table and CSV templates to use unified content type logic - Remove 'Other language link' column from HTML page list table - Maintain UTF-8 BOM encoding and French translations in CSV exports This ensures consistency between HTML table and CSV exports while simplifying the table interface.
Merged
Contributor
Author
|
Once pages are tagged, remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not delete the following line
@netlify /en/pages-to-review/
Commit History: