-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement waitFor tool #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/tools/wait-for-element.ts
Outdated
|
|
||
| await result.element.waitForDisplayed(waitOptions); | ||
|
|
||
| console.error(`Element with ${result.queryDescription} ${actionDescription} successfully`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.error?
${actionDescription} successfully
shouldn't it be in the past tense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.error is used to output debug logs.
MCP servers have two ways of communication as of now — stdio and server sent events. we use stdio as a simple and effective way for a local server. In this case, communication with client is performed via stdout interface, so we can't do any console.logs. And stderr can be used for debug logging.
What's done?
openAndWaitinstead ofurl.