feat: ability to connect to repl server by port #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
force-pushed
the
TESTPLANE-739.ability_connect_to_repl_port
branch
from
2491a6a to
7a133f4
Compare
commit: |
KuznetsovRoman
requested changes
Oct 6, 2025
| const testCwd = path.dirname(session.executionContext.ctx.currentTest.file!); | ||
| process.chdir(testCwd); | ||
|
|
||
| const replServer = await import("node:repl").then(m => m.start({ prompt: "> " })); |
Member
There was a problem hiding this comment.
We should return dynamic import here.
When its static, like you did it now, it is imported on each testplane run, even when repl is not used.
So it should be dynamic, so we could save some time when we dont need repl feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
--repl-portcli option in order to be able to specify port on which create net server to be able to connect to repl server. If port is not specified then free port is engaged