Skip to content

Conversation

@Meriem-BenIsmail
Copy link
Member

@Meriem-BenIsmail Meriem-BenIsmail commented Jan 31, 2025

Description

Fixes #416.

image

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--417.org.readthedocs.build/en/417/
💡 JupyterLite preview: https://jupytergis--417.org.readthedocs.build/en/417/lite

@Meriem-BenIsmail Meriem-BenIsmail added the bug Something isn't working label Jan 31, 2025
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch Meriem-BenIsmail/jupytergis/fileupload-input

@github-actions
Copy link
Contributor

Integration tests report: appsharing.space

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks for the quick fix!

@martinRenou
Copy link
Member

Visual regression tests fail the same way on main, let's go ahead and merge

@martinRenou martinRenou merged commit e37ca82 into geojupyter:main Jan 31, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Readonly Input Field for Selected File Path

2 participants